fix: update mysqldump options to use --ssl-mode=DISABLED for modern versions #18044
Conversation
|
Hi there - thanks for this! Can you please re-target this PR to point to the You don't need to close and re-open. After you create a pull request, you can modify the base branch so that the changes in the pull request are compared against a different branch. By changing the base branch of your original pull request rather than opening a new one with the correct base branch, you’ll be able to keep valuable work and discussion.
Thanks! |
|
Hi @snipe thanks for letting me know. I changed the base branch. |
uberbrady
left a comment
uberbrady
left a comment
There was a problem hiding this comment.
This looks good to me - the db-dumper package does have a setSkipSsl() method you can call on it, but I don't see anywhere that the laravel-backup package actually calls that. So this is probably the best way to go.
|
This seems to be causing issues for some users :( #18118 |
3 participants
I still have this issue 17004 in the latest deployment. This is a quick fix to it already tested locally.
In the recent version of mariadb the argument changed and should follow as committed.